Out of Range: unified Text Alpha driving the Text Designer overlay#163
Open
Krathe82 wants to merge 4 commits into
Open
Out of Range: unified Text Alpha driving the Text Designer overlay#163Krathe82 wants to merge 4 commits into
Krathe82 wants to merge 4 commits into
Conversation
The Text Designer now renders all unit text, so the legacy per-element OOR text alphas (oorNameTextAlpha / oorHealthTextAlpha) acted on the now-hidden legacy FontStrings and did nothing — the reported 'Name Text Alpha doesn't work since the last update'. Rework it to a single unified 'Text Alpha' that dims the whole TD overlay out of range: - Render.lua: at the end of Render:UpdateFrame, fade frame._tdOverlay via SetAlphaFromBoolean(dfInRange, 1, oorTextAlpha) when oorEnabled (secret-safe; dfInRange may be a secret boolean). oorEnabled off -> overlay stays 1 and the frame-level OOR fade cascades to it as a child. - Config: new oorTextAlpha (party + raid), default 0.55. - Options: replace the Name/Health Text Alpha sliders with one 'Text Alpha'. - ExportCategories: export oorTextAlpha. - Core/Profile: MigrateOORTextAlpha folds a customised legacy oorNameTextAlpha (changed from its old default of 1) into oorTextAlpha, per-profile guarded. Legacy keys left in place (harmless). Test-mode TD OOR preview is unchanged (separate testData path).
Let test frames (dfIsTestFrame) through the OOR overlay-fade block. TestMode already sets frame.dfInRange from the test OOR state (gated on testShowOutOfRange), so the same secret-safe SetAlphaFromBoolean path now dims the TD overlay in the test preview, matching live. The Options mock preview (isPreview, not a test frame) stays skipped — it has no range state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported: the Name Text Alpha setting (Fading → Out of Range) stopped working after the Text Designer update.
Cause: the Text Designer now renders all unit text, so the old per-element
oorNameTextAlpha(and the other per-element OOR text alphas) no longer drive anything.Fix: a single unified Text Alpha (
oorTextAlpha, default 0.55) fades the whole Text Designer overlay out of range viaSetAlphaFromBoolean. The Fading → Out of Range page collapses the old Name/Health Text Alpha sliders into one Text Alpha. A per-profile guarded migration folds a customised legacyoorNameTextAlphainto the new value (default-config users just get the new default). Applied in test mode too so the fade previews, and exported under the text category.